Fix requireSync within node#13
Merged
Merged
Conversation
Comparing against the output of the babel plugin, the comparison in `requireSync` should be an identifier, not a string (otherwise, the conditional will always be `true`).
Owner
|
Good job, thank you. |
Owner
|
This is released in version npm i -D typescript-loadable-components-plugin@latest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Comparing against the output of the babel plugin, the comparison in
requireSyncshould be an identifier, not a string (otherwise, theconditional will always be
true).Added a
preparenpm script as well so that the built version can be used with git / non-published imports (needed for my own use, fine to remove it if needed).